Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/34215 )
Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test
......................................................................
Patch Set 4:
(5 comments)
File osmo_dia2gsup-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/b08337ce_0eb…
PS2, Line 19: rebar3 escriptize
Maybe copy the resulting `osmo-dia2gsup` to
`/usr/local/bin` here, so that it's easier to call it?
I tried but
$distro-erlang image is already changing the user to some non-root user which then
doesn't have rights to copy stuff to /usr/local/bin.
I didn't want to go the way to change that and all dependent images, so I'm just
running the binary from the local path since anyway it's only used in this container.
https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/256626d8_924…
PS2, Line 26: --config /data/osmo_dia2gsup.config
You're passing the config file twice. […]
Ack
File ttcn3-dia2gsup-test/Makefile:
https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/0bb5d4bd_6c7…
PS2, Line 1:
ws
Ack
File ttcn3-dia2gsup-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/a763f9cc_577…
PS2, Line 6: debian-bookworm-erlang
This looks like a dependency of
`osmo_dia2gsup-$IMAGE_SUFFIX`, and should not be listed here if so. […]
Ack
https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/7f2acb00_cf6…
PS2, Line 31: /bin/sh -c "ERL_FLAGS='-config /data/osmo_dia2gsup.config'
/tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup --config /data/osmo_dia2gsup.config
>/data/osmo_dia2gsup.log 2>&1"
This line is already specified in `CMD` of the
respective Dockerfile, why duplicating it here?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/34215
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7
Gerrit-Change-Number: 34215
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Aug 2023 12:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment