Attention is currently required from: osmith, fixeria.

View Change

5 comments:

• File osmo_dia2gsup-master/Dockerfile:

  • Patch Set #2, Line 19: rebar3 escriptize

    Maybe copy the resulting `osmo-dia2gsup` to `/usr/local/bin` here, so that it's easier to call it?

    I tried but $distro-erlang image is already changing the user to some non-root user which then doesn't have rights to copy stuff to /usr/local/bin.
    I didn't want to go the way to change that and all dependent images, so I'm just running the binary from the local path since anyway it's only used in this container.

  • Patch Set #2, Line 26: --config /data/osmo_dia2gsup.config

    You're passing the config file twice. […]

    Ack

• File ttcn3-dia2gsup-test/Makefile:

  • Patch Set #2, Line 1:

    ws

    Ack

• File ttcn3-dia2gsup-test/jenkins.sh:

  • Patch Set #2, Line 6: debian-bookworm-erlang

    This looks like a dependency of `osmo_dia2gsup-$IMAGE_SUFFIX`, and should not be listed here if so. […]

    Ack

  • Patch Set #2, Line 31: /bin/sh -c "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup --config /data/osmo_dia2gsup.config >/data/osmo_dia2gsup.log 2>&1"

    This line is already specified in `CMD` of the respective Dockerfile, why duplicating it here?

    Ack

To view, visit change 34215. To unsubscribe, or for help writing mail filters, visit settings.