Attention is currently required from: fixeria, pespin.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email )

Change subject: stream: Add and use helper function osmo_ipa_push_headers() ......................................................................

Patch Set 21:

(3 comments)

File include/osmocom/netif/ipa.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/b47e2a42_6755dcd6 PS20, Line 6: #include <osmocom/netif/stream.h>

This header file contains a protocol definition, and making it contain the whole stream API does not […]

Done

File src/ipa.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/7ede88bc_d251f762 PS20, Line 443: struct msgb *msg

If we go for exposing this API (see my other comment), the `msg` pointer should become the first arg […]

Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/bdd42606_87f1ac99 PS20, Line 456: osmo_ipa_stream_srv_send

I agree with fixeria here, I already shared my concerns about this kind of API ;)

Done