Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File include/osmocom/netif/ipa.h:

  • Patch Set #20, Line 6: #include <osmocom/netif/stream.h>

    This header file contains a protocol definition, and making it contain the whole stream API does not […]

    Done

• File src/ipa.c:

  • Patch Set #20, Line 443: struct msgb *msg

    If we go for exposing this API (see my other comment), the `msg` pointer should become the first arg […]

    Done

  • Patch Set #20, Line 456: osmo_ipa_stream_srv_send

    I agree with fixeria here, I already shared my concerns about this kind of API ;)

    Done

To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.