Attention is currently required from: osmith, laforge, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command ......................................................................
Patch Set 10:
(3 comments)
Patchset:
PS10: Can you shed some light on the nc/num_nodes part? Other stuff LGTM.
File include/osmocom/ctrl/control_if.h:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/4e80c5fb_e17ff085 PS10, Line 39: struct ctrl_handle *ctrl_interface_setup2(void *data, uint16_t default_port, ctrl_cmd_lookup lookup, unsigned int nc); what's nc?
File src/ctrl/control_if.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/ec0e960e_01ee7968 PS10, Line 1038: * \param[in] nc Number of CTRL nodes to allocate, 0 for default. better call this something more descriptive, like num_nodes.
I wonder why is this new param needed at all or its purpose tbh.