Attention is currently required from: osmith, laforge, msuraev.

View Change

3 comments:

• Patchset:

  • Patch Set #10:

    Can you shed some light on the nc/num_nodes part? Other stuff LGTM.

• File include/osmocom/ctrl/control_if.h:

  • Patch Set #10, Line 39: struct ctrl_handle *ctrl_interface_setup2(void *data, uint16_t default_port, ctrl_cmd_lookup lookup, unsigned int nc);

    what's nc?

• File src/ctrl/control_if.c:

  • Patch Set #10, Line 1038: * \param[in] nc Number of CTRL nodes to allocate, 0 for default.

    better call this something more descriptive, like num_nodes.

    I wonder why is this new param needed at all or its purpose tbh.

To view, visit change 30444. To unsubscribe, or for help writing mail filters, visit settings.