Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28210 )

Change subject: fix rare segfault in MGCP client handling ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28210/comment/a26a33f8_7ebd1f5c PS1, Line 134: gscon_forget_mgw_endpoint_ci(conn, ci);

wouldn't it make sense to call osmo_mgcpc_ep_ci_dlcx(ci); inside gscon_forget_mgw_endpoint_ci() befo […]

the dlcx() emits events that may cause FSMs to terminate and clean up (again), so we need to invalidate the reference to the ci first.

The *_forget_* is exactly about NULLing references in various places, the actual reason for NULLing should be kept apart.