Attention is currently required from: pespin.

Patch set 1:Code-Review +2

View Change

1 comment:

• File src/osmo-bsc/assignment_fsm.c:

  • Patch Set #1, Line 134: gscon_forget_mgw_endpoint_ci(conn, ci);

    wouldn't it make sense to call osmo_mgcpc_ep_ci_dlcx(ci); inside gscon_forget_mgw_endpoint_ci() befo […]

    the dlcx() emits events that may cause FSMs to terminate and clean up (again),
    so we need to invalidate the reference to the ci first.

    The *_forget_* is exactly about NULLing references in various places,
    the actual reason for NULLing should be kept apart.

To view, visit change 28210. To unsubscribe, or for help writing mail filters, visit settings.