Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email ) Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 6: (4 comments) File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/37840/comment/b1f4038e_33d15643?usp=em… : PS5, Line 113: apply_lchan:bool = True Done https://gerrit.osmocom.org/c/pysim/+/37840/comment/58c6023d_6f5fae66?usp=em… : PS5, Line 124: pdu = self.cla4lchan(pdu[0:2]) + pdu[2:] looks like I forgot to put an if here, thanks! https://gerrit.osmocom.org/c/pysim/+/37840/comment/aabca5ec_0e12986e?usp=em… : PS5, Line 130: apply_lchan:bool = True Done https://gerrit.osmocom.org/c/pysim/+/37840/comment/7299a8ef_1478e12e?usp=em… : PS5, Line 178: apply_lchan:bool = True I think that does not work. The idea is that that the API user can decide to override the lchan CLA byte patching at any time. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Aug 2024 10:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>