Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )
Change subject: ara_m: use class byte of current lchan ......................................................................
Patch Set 6:
(4 comments)
File pySim/commands.py:
https://gerrit.osmocom.org/c/pysim/+/37840/comment/b1f4038e_33d15643?usp=ema... : PS5, Line 113: apply_lchan:bool = True
Unused in this function?
Done
https://gerrit.osmocom.org/c/pysim/+/37840/comment/58c6023d_6f5fae66?usp=ema... : PS5, Line 124: pdu = self.cla4lchan(pdu[0:2]) + pdu[2:]
... […]
looks like I forgot to put an if here, thanks!
https://gerrit.osmocom.org/c/pysim/+/37840/comment/aabca5ec_0e12986e?usp=ema... : PS5, Line 130: apply_lchan:bool = True
Unused in this function?
Done
https://gerrit.osmocom.org/c/pysim/+/37840/comment/7299a8ef_1478e12e?usp=ema... : PS5, Line 178: apply_lchan:bool = True
Maybe move this param to the constructor and set `self. […]
I think that does not work. The idea is that that the API user can decide to override the lchan CLA byte patching at any time.