Attention is currently required from: fixeria, laforge.

View Change

4 comments:

• File pySim/commands.py:

  • Patch Set #5, Line 113: apply_lchan:bool = True

    Unused in this function?

    Done

  • Patch Set #5, Line 124: pdu = self.cla4lchan(pdu[0:2]) + pdu[2:]

    ... […]

    looks like I forgot to put an if here, thanks!

  • Patch Set #5, Line 130: apply_lchan:bool = True

    Unused in this function?

    Done

  • Patch Set #5, Line 178: apply_lchan:bool = True

    Maybe move this param to the constructor and set `self. […]

    I think that does not work. The idea is that that the API user can decide to override the lchan CLA byte patching at any time.

To view, visit change 37840. To unsubscribe, or for help writing mail filters, visit settings.