Attention is currently required from: arehbein, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 ) Change subject: gsm/ipa: Add segmentation callback ...................................................................... Patch Set 3: (1 comment) File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/9c53568a_dbc2c5f8 PS2, Line 730: msg->data_len < total_len This (is supposed to) check the case where the msgb is not large enough to contain a complete message. So e.g. msgb was allocated with a size of 1024, payload_len turns out to be 2342. I'm not 100% sure if ->data_len is the correct field, though. Do we want msgb_tailroom() + msgb_length() ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Gerrit-Change-Number: 33083 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein &lt;arehbein(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: arehbein &lt;arehbein(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 06 Jun 2023 14:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: comment