Attention is currently required from: arehbein, fixeria.

View Change

1 comment:

• File src/gsm/ipa.c:

  • Patch Set #2, Line 730: msg->data_len < total_len

    Is `msg->data_len < total_len` really an error? Given that the underlying transport is usually TCP, […]

    This (is supposed to) check the case where the msgb is not large enough to contain a complete message.

    So e.g. msgb was allocated with a size of 1024, payload_len turns out to be 2342.

    I'm not 100% sure if ->data_len is the correct field, though. Do we want msgb_tailroom() + msgb_length() ?

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.