Attention is currently required from: pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email )

Change subject: Refactoring encoding of mobile identity at mobile application ......................................................................

Patch Set 6:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/764ccc95_b155d748 PS5, Line 9: Deprecated functions gsm48_generate_mid_from_*() are replaced by

yay! \o/

Done

Patchset:

PS5:

Just to make sure, did you test a bit this? This kind of patches can easily add regressions. […]

Yes, it is tested. It is used for every attach/detach/location update using IMSI and TMSI. Also I tested it with voice group call, where it is used to identify the talker.

File src/host/layer23/src/mobile/gsm48_mm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/a18d5ba1_023dba70 PS5, Line 276: int gsm48_encode_mi(struct osmocom_ms *ms, struct msgb *msg, bool tlv, uint8_t mi_type, bool emergency_imsi)

Did you think about having 2 functions gsm48_encode_mi_tlv() and gsm48_encode_mi_lv()? […]

Done