Attention is currently required from: pespin.

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 9: Deprecated functions gsm48_generate_mid_from_*() are replaced by

    yay! \o/

    Done

• Patchset:

  • Patch Set #5:

    Just to make sure, did you test a bit this? This kind of patches can easily add regressions. […]

    Yes, it is tested. It is used for every attach/detach/location update using IMSI and TMSI. Also I tested it with voice group call, where it is used to identify the talker.

• File src/host/layer23/src/mobile/gsm48_mm.c:

  • Patch Set #5, Line 276: int gsm48_encode_mi(struct osmocom_ms *ms, struct msgb *msg, bool tlv, uint8_t mi_type, bool emergency_imsi)

    Did you think about having 2 functions gsm48_encode_mi_tlv() and gsm48_encode_mi_lv()? […]

    Done

To view, visit change 34484. To unsubscribe, or for help writing mail filters, visit settings.