Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )

Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/221d65ad_3074e131 PS2, Line 13: gsmtap

Ok, let's see what the others think about the command style/consistency.

Ack

File src/host/layer23/include/osmocom/bb/common/l23_app.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/17421f82_f6d394f5 PS3, Line 20: l23_gsmtap_category

Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries?

Ack

File src/host/layer23/src/common/vty.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/e6ff6ea6_4de2c66a PS3, Line 138: gsmtap_sapi_names

There exists gsmtap_gsm_channel_names[] in libosmocore. […]

Ack