Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/221d65ad_3074e131 PS2, Line 13: gsmtap
Ok, let's see what the others think about the command style/consistency. Ack
File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/17421f82_f6d394f5 PS3, Line 20: l23_gsmtap_category
Maybe l23_gsmtap_gprs_category? Or have GPRS prefix in all enum entries? Ack
File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/e6ff6ea6_4de2c66a PS3, Line 138: gsmtap_sapi_names
There exists gsmtap_gsm_channel_names[] in libosmocore. […] Ack
-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:36:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment