Attention is currently required from: jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 )

Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ......................................................................

Patch Set 12:

(1 comment)

File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/d51ac71b_f6dcaa3a PS12, Line 22: #ifdef HAVE_SYS_SOCKET_H the problem I see here is that this will actually be evaluated when building the app against libosmocore reading the header. As a result, if the app doesn't have the configure.ac check setting this ifdef, this will end up in weird situations. Probably the best solutions would be, instead of HAVE_SYS_SOCKET_H here, to avoid adding this .h and .h/.c depending on it into build targets if EMBEDDED is defined.