Attention is currently required from: jolly.

View Change

1 comment:

• File include/osmocom/gsm/gsm0808.h:

  • Patch Set #12, Line 22: #ifdef HAVE_SYS_SOCKET_H

    the problem I see here is that this will actually be evaluated when building the app against libosmocore reading the header. As a result, if the app doesn't have the configure.ac check setting this ifdef, this will end up in weird situations.
    Probably the best solutions would be, instead of HAVE_SYS_SOCKET_H here, to avoid adding this .h and .h/.c depending on it into build targets if EMBEDDED is defined.

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.