Attention is currently required from: laforge.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34920?usp=email )

Change subject: SI10: Fix uninitialized l_bts pointer ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/system_information.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34920/comment/7c9b7ab8_bb2ba35f PS1, Line 1424: struct gsm_bts *s_bts = conn->lchan->ts->trx->bts, *l_bts;

are you sure you don't need to NULL-intitialize it? At first sight it looks like it's possible to c […]

As described in the commit message, l_bts will be set before calling si10_rest_octets_encode_other.

To make it clearer, I initialize l_bts with NULL and use OSMO_ASSERT(l_bts) to show/check if the pointer is set.