Attention is currently required from: laforge.

View Change

1 comment:

• File src/osmo-bsc/system_information.c:

  • Patch Set #1, Line 1424: struct gsm_bts *s_bts = conn->lchan->ts->trx->bts, *l_bts;

    are you sure you don't need to NULL-intitialize it? At first sight it looks like it's possible to c […]

    As described in the commit message, l_bts will be set before calling si10_rest_octets_encode_other.

    To make it clearer, I initialize l_bts with NULL and use OSMO_ASSERT(l_bts) to show/check if the pointer is set.

To view, visit change 34920. To unsubscribe, or for help writing mail filters, visit settings.