Attention is currently required from: neels.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33674 )

Change subject: ASCI: Add option to switch on or off ASCI support ......................................................................

Patch Set 2:

(1 comment)

File src/libmsc/msc_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33674/comment/f4c9050f_b8256981 PS2, Line 2088: struct msc_a *msc_a

( […]

msc_a_cm_service_type_to_use() is a function to be uses in conjunction with msc_a. I think that the caller should not know about what service is enabled or not. Using net instead of msc_a is ok, because msc_a_cm_service_type_to_use() does not use msc_a structure.