Attention is currently required from: neels.
View Change
1 comment:
File src/libmsc/msc_a.c:
Patch Set #2, Line 2088: struct msc_a *msc_a
( […]
msc_a_cm_service_type_to_use() is a function to be uses in conjunction with msc_a. I think that the caller should not know about what service is enabled or not. Using net instead of msc_a is ok, because msc_a_cm_service_type_to_use() does not use msc_a structure.
To view, visit change 33674. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753
Gerrit-Change-Number: 33674
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Jul 2023 11:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: comment