Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30619 ) Change subject: pdch: Introduce APIs to print PDCH name ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File src/pdch.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/49026ac4_4fd3be33 PS1, Line 195: unsigned int Done File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/55e21f85_62168255 PS1, Line 1339: Done File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/bf1b6ae5_6d352d9d PS2, Line 1346: pdch_name_buf I still think it makes sense to do NULL checking here. We had a similar discussion when Neels was refactoring osmo-{bsc,msc} and in the end after a few segfaults we agreed that doing NULL checking is better. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If18cb4a48237751e0dddede6793191b36dfe386d Gerrit-Change-Number: 30619 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Dec 2022 11:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment