Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30619 )

Change subject: pdch: Introduce APIs to print PDCH name ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

File src/pdch.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/49026ac4_4fd3be33 PS1, Line 195: unsigned int

size_t?

Done

File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/55e21f85_62168255 PS1, Line 1339:

" No newline at end of revision file. […]

Done

File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30619/comment/bf1b6ae5_6d352d9d PS2, Line 1346: pdch_name_buf I still think it makes sense to do NULL checking here. We had a similar discussion when Neels was refactoring osmo-{bsc,msc} and in the end after a few segfaults we agreed that doing NULL checking is better.