Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

3 comments:

• File src/pdch.h:

  • Patch Set #1, Line 195: unsigned int

    size_t?

    Done

• File src/pdch.cpp:

  • Patch Set #1, Line 1339:

    " No newline at end of revision file. […]

    Done

• File src/pdch.cpp:

  • Patch Set #2, Line 1346: pdch_name_buf

    I still think it makes sense to do NULL checking here. We had a similar discussion when Neels was refactoring osmo-{bsc,msc} and in the end after a few segfaults we agreed that doing NULL checking is better.

To view, visit change 30619. To unsubscribe, or for help writing mail filters, visit settings.