Attention is currently required from: falconia, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/d19bf164_7039b95a PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
we usually call these free as a counterpart of alloc. […]
Well, this "usual" naming does not apply here:
``` include/osmocom/hlr/gsup_router.h:int gsup_route_del_conn(struct osmo_gsup_conn *conn); include/osmocom/hlr/hlr_ussd.h:void ussd_route_del(struct hlr_ussd_route *rt); ```
This patch is consistent with the existing code, and IMO we cannot require this from contributors if we ourselves don't always follow such requirements it in the existing code...