Attention is currently required from: falconia, pespin.

View Change

1 comment:

• File include/osmocom/hlr/hlr_sms.h:

  • Patch Set #2, Line 17: void smsc_del(struct hlr_smsc *smsc);

    we usually call these free as a counterpart of alloc. […]

    Well, this "usual" naming does not apply here:

    ```
    include/osmocom/hlr/gsup_router.h:int gsup_route_del_conn(struct osmo_gsup_conn *conn);
    include/osmocom/hlr/hlr_ussd.h:void ussd_route_del(struct hlr_ussd_route *rt);
    ```

    This patch is consistent with the existing code, and IMO we cannot require this from contributors if we ourselves don't always follow such requirements it in the existing code...

To view, visit change 34448. To unsubscribe, or for help writing mail filters, visit settings.