Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29618 ) Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... Patch Set 4: (2 comments) File src/ice1usb_proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/42d3e0ae_cc9420ce PS3, Line 68: int16_t err_acc; /*!< Accumulated error */ I added a reference to the next (yet to be tagged/release) version (since it'll be the first to have it) and the exact commit. Note that this also means the ice1usb_proto.h here is different from the one in the firmware repo. Unless we add two commits for every ice1usb_proto.h change in the future (because you can't include the sha of the commit in the commit itself obviously unless you want to start looking for sha1 collisions ...) File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/60ef83a1_92df85a4 PS3, Line 715: "Some values will be zeroed\n", Yup notice is probably a bit much. Switched to DEBUG. Also added a wall of text explaining why this is needed and why the opposite case is not an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 4 Gerrit-Owner: tnt &lt;tnt(a)246tNt.com&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Thu, 06 Oct 2022 08:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-MessageType: comment