Attention is currently required from: laforge.

View Change

2 comments:

• File src/ice1usb_proto.h:

  • Patch Set #3, Line 68: int16_t err_acc; /*!< Accumulated error */

    I think it might make sense to add a comment that this field was added by firmware version `git desc […]

    I added a reference to the next (yet to be tagged/release) version (since it'll be the first to have it) and the exact commit.

    Note that this also means the ice1usb_proto.h here is different from the one in the firmware repo. Unless we add two commits for every ice1usb_proto.h change in the future (because you can't include the sha of the commit in the commit itself obviously unless you want to start looking for sha1 collisions ...)

• File src/usb.c:

  • Patch Set #3, Line 715: "Some values will be zeroed\n",

    I don't think we want to send one NOTICE every status_cb. […]

    Yup notice is probably a bit much. Switched to DEBUG.

    Also added a wall of text explaining why this is needed and why the opposite case is not an issue.

To view, visit change 29618. To unsubscribe, or for help writing mail filters, visit settings.