[M] Change in osmo-msc[master]: add vty setting for ThemWi RTP formats - gerrit-log

17 Dec 2025


      Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email )
Change subject: add vty setting for ThemWi RTP formats
......................................................................
Patch Set 2:
(1 comment)
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/8647e217_a0a13e2b?usp=... :
PS2, Line 711: DEFUN(cfg_msc_twformat1,
...
Why are you adding 4 commands instead of 1 with optional arguments? […]
I copied the approach that is used in osmo-bsc for per-BTS `codec-support`, `amr tch-f modes` and `amr tch-h modes` settings. But the approach you just indicated is clearly much better - I will rework my patch!
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 2
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 17 Dec 2025 17:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de