Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email ) Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ...................................................................... Patch Set 2: (2 comments) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/4ce473bf_389dc924?u... : PS2, Line 428: int on missing docstring File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/5929a149_732ffe98?u... : PS2, Line 831: ofd_wq_mode ? 1 : 0, A boolean is expected here, why do you convert it to an integer? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5d31bedd7d265d18f6e475ccbc94ced80598d04 Gerrit-Change-Number: 41702 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 17 Dec 2025 17:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No