Attention is currently required from: fixeria.

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email )

Change subject: Introduce a new 'hexstr' type to represent hex-strings ......................................................................

Patch Set 2:

(1 comment)

File src/osmocom/utils.py:

https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/96ebe076_de41a... : PS2, Line 141: hexstr

Class names should use CamelCase in python (according to PEP 8): […]

the "problem" then is that we already have osmocom.utils.Hexstr as a type for type annotations: "Hexstr = NewType('Hexstr', str)"

Indeed, once we have a proper, hexstr type (as introduced by this patch) *and* ported over all of pySim to that, the former would no longer be neeed. But simply replacing the existin Hexstr with that new 'class Hexstr' you propose - I'm not sure what kind of fallout that would mean?