Attention is currently required from: fixeria.

View Change

1 comment:

• File src/osmocom/utils.py:

  • Patch Set #2, Line 141: hexstr

    Class names should use CamelCase in python (according to PEP 8): […]

    the "problem" then is that we already have osmocom.utils.Hexstr as a type for type annotations: "Hexstr = NewType('Hexstr', str)"

    Indeed, once we have a proper, hexstr type (as introduced by this patch) *and* ported over all of pySim to that, the former would no longer be neeed. But simply replacing the existin Hexstr with that new 'class Hexstr' you propose - I'm not sure what kind of fallout that would mean?

To view, visit change 38023. To unsubscribe, or for help writing mail filters, visit settings.