Attention is currently required from: iedemam, neels, laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 8: (3 comments) Patchset: PS8: From my side fix the 2 small things and I'm happy with it. File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/12550a5a_acc5aa69 PS8, Line 2182: (bts->chan_alloc_tch_signalling_policy == BTS_TCH_SIGNALLING_VOICE && Alignment should be done using a few spaces to end up under "b" character here from previous line here. I'm sorry to be picky here but this code path is quite an important one in channel allocation so I want to have it as clear as possible. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/7f1cfd3b_bd863d1d PS8, Line 593: DEFUN_DEPRECATED(cfg_bts_chan_alloc_allow_tch_for_signalling, Better use DEFUN_ATTR(..., CMD_ATTR_IMMEDIATE|CMD_ATTR_DEPRECATED) here instead of "DEFUN_DEPRECTATED()", to avoid lossing the "immediate" flag. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 8 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 12:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment