Attention is currently required from: iedemam, neels, laforge, fixeria, dexter.
3 comments:
Patchset:
From my side fix the 2 small things and I'm happy with it.
File src/osmo-bsc/abis_rsl.c:
Patch Set #8, Line 2182: (bts->chan_alloc_tch_signalling_policy == BTS_TCH_SIGNALLING_VOICE &&
Alignment should be done using a few spaces to end up under "b" character here from previous line here.
I'm sorry to be picky here but this code path is quite an important one in channel allocation so I want to have it as clear as possible.
File src/osmo-bsc/bts_vty.c:
Patch Set #8, Line 593: DEFUN_DEPRECATED(cfg_bts_chan_alloc_allow_tch_for_signalling,
Better use DEFUN_ATTR(..., CMD_ATTR_IMMEDIATE|CMD_ATTR_DEPRECATED) here instead of "DEFUN_DEPRECTATED()", to avoid lossing the "immediate" flag.
To view, visit change 28276. To unsubscribe, or for help writing mail filters, visit settings.