Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30303 )

Change subject: rate_ctr: use multiple timerfd ......................................................................

Patch Set 3:

(3 comments)

Patchset:

PS3: IIUC this triggers 4 timerds per second

File src/rate_ctr.c:

https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/680b87ee_bd21f391 PS3, Line 350: llist_for_each_entry(ctrg, &rate_ctr_groups, list) { you may want to have a generic function passing RATE_CTR_INTV_* param here instead of repeating the same code like 4 times.

https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/e1b9182a_735ddcc5 PS3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec); I'm not liking this new approach because it could output unconsistent metrics, for instance if the main loop poll() call triggers in the same operation and fds are handled this way: rate_ctr_timer_sec statsd_whatever_output_timer rate_ctr_timer_hour

Or this way: rate_ctr_timer_hour statsd_whatever_output_timer rate_ctr_timer_sec

You end up having statsd report with weird figures where numbers don't match.