Attention is currently required from: msuraev.
3 comments:
Patchset:
IIUC this triggers 4 timerds per second
File src/rate_ctr.c:
Patch Set #3, Line 350: llist_for_each_entry(ctrg, &rate_ctr_groups, list) {
you may want to have a generic function passing RATE_CTR_INTV_* param here instead of repeating the same code like 4 times.
Patch Set #3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec);
I'm not liking this new approach because it could output unconsistent metrics, for instance if the main loop poll() call triggers in the same operation and fds are handled this way:
rate_ctr_timer_sec
statsd_whatever_output_timer
rate_ctr_timer_hour
Or this way:
rate_ctr_timer_hour
statsd_whatever_output_timer
rate_ctr_timer_sec
You end up having statsd report with weird figures where numbers don't match.
To view, visit change 30303. To unsubscribe, or for help writing mail filters, visit settings.