[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable - gerrit-log

25 Apr 2023


      Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 )
Change subject: contrib/jenkins.sh: add PFCP variable
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/f6675a84_583b3e40 
PS2, Line 9: PFCP=${PFCP:-"--enable-pfcp"}
IMHO it should rather be consistent with 'WITH_MANUALS':
WITH_PFCP=[0|1]
and add '--enable-pfcp' below in 'if PFCP == 1'
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/3e421e93_fd6b66d0 
PS2, Line 48: =
+= here so that WITH_MANUALS == 1 does not lose the --enable-pfcp again
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e
Gerrit-Change-Number: 32430
Gerrit-PatchSet: 2
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment