Attention is currently required from: osmith.
Patch set 2:Code-Review -1
View Change
2 comments:
File contrib/jenkins.sh:
Patch Set #2, Line 9: PFCP=${PFCP:-"--enable-pfcp"}
IMHO it should rather be consistent with 'WITH_MANUALS':
WITH_PFCP=[0|1]
and add '--enable-pfcp' below in 'if PFCP == 1'
Patch Set #2, Line 48: =
+= here so that WITH_MANUALS == 1 does not lose the --enable-pfcp again
To view, visit change 32430. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e
Gerrit-Change-Number: 32430
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment