Attention is currently required from: fixeria, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27758 )

Change subject: osmo-bts-trx: use C/I in the AMR link adaptation loop ......................................................................

Patch Set 5:

(2 comments)

File src/osmo-bts-trx/amr_loop.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/0d7fa69b_3bdab3df PS5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5; is the hysteresis missing here (see thresh_upper_cb)?

https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/68660b10_06858b55 PS5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) { just to be sure, is the "else if" here intentional, instead of just "if"? given that dl_cmr is an uint8_t, it looks like with this logic it can only alternate between 0 and 1.