Attention is currently required from: fixeria, pespin, dexter.

View Change

2 comments:

• File src/osmo-bts-trx/amr_loop.c:

  • Patch Set #5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5;

    is the hysteresis missing here (see thresh_upper_cb)?

  • Patch Set #5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) {

    just to be sure, is the "else if" here intentional, instead of just "if"? given that dl_cmr is an uint8_t, it looks like with this logic it can only alternate between 0 and 1.

To view, visit change 27758. To unsubscribe, or for help writing mail filters, visit settings.