Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29512 )
Change subject: osmux: Proper encoding of osmux frames when when AMR FT changes ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/osmux.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/41e78fbd_ecd777c2 PS1, Line 470: !state.rtph Why are you changing this? I guess because below in your code you're doing !foo. The existing code is doing "foo == NULL", so I would rather stay consistent. Not really critical, but still catches an eye.
https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/05b819ea_b3da177d PS1, Line 535: struct amr_hdr *amrh const?