Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29512 ) Change subject: osmux: Proper encoding of osmux frames when when AMR FT changes ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/41e78fbd_ecd777c2 PS1, Line 470: !state.rtph Why are you changing this? I guess because below in your code you're doing !foo. The existing code is doing "foo == NULL", so I would rather stay consistent. Not really critical, but still catches an eye. https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/05b819ea_b3da177d PS1, Line 535: struct amr_hdr *amrh const? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I25eb6ee54c898f575cc71ccfd6d190fe51d56dbe Gerrit-Change-Number: 29512 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment