Attention is currently required from: pespin.
Patch set 1:Code-Review +1
View Change
2 comments:
File src/osmux.c:
Patch Set #1, Line 470: !state.rtph
Why are you changing this? I guess because below in your code you're doing !foo. The existing code is doing "foo == NULL", so I would rather stay consistent. Not really critical, but still catches an eye.
Patch Set #1, Line 535: struct amr_hdr *amrh
const?
To view, visit change 29512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I25eb6ee54c898f575cc71ccfd6d190fe51d56dbe
Gerrit-Change-Number: 29512
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Sep 2022 08:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment