Attention is currently required from: pespin.

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email )

Change subject: drivers/dahdi: fix always true cond ......................................................................

Patch Set 1:

(1 comment)

File drivers/dahdi/xpp/xbus-core.c:

https://gerrit.osmocom.org/c/dahdi-linux/+/39593/comment/df787733_4a17f57e?u... : PS1, Line 116: if (xbus->label) {

are you sure about this one? Looks like you are removing a check againstbeing len(xbus->label)>0 her […]

Yes, from the commit message:

``` xpp/xbus-core.c: In function 'xbus_check_unique': xpp/xbus-core.c:116:13: warning: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Waddress] 116 | if (xbus->label && *(xbus->label)) { | ^~~~ ```

If the length should be checked, it would need to be e.g. xbus->label[0]. I'm not sure if the author intended that. By just removing the check we get the same behavior as before and get rid of the build failure.