Attention is currently required from: pespin.

View Change

1 comment:

• File drivers/dahdi/xpp/xbus-core.c:

  • Patch Set #1, Line 116: if (xbus->label) {

    are you sure about this one? Looks like you are removing a check againstbeing len(xbus->label)>0 her […]

    Yes, from the commit message:

    ```
    xpp/xbus-core.c: In function 'xbus_check_unique':
    xpp/xbus-core.c:116:13: warning: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Waddress]
      116 |         if (xbus->label && *(xbus->label)) {
          |             ^~~~
    ```

    If the length should be checked, it would need to be e.g. xbus->label[0]. I'm not sure if the author intended that. By just removing the check we get the same behavior as before and get rid of the build failure.

To view, visit change 39593. To unsubscribe, or for help writing mail filters, visit settings.