Jenkins Builder has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39277?usp=email )
Change subject: nokia_site: change RSL bootstrap logic ......................................................................
Patch Set 1:
(27 comments)
File src/osmo-bsc/bts_nokia_site.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/e16fdbc0_3c577e5c?usp=... : PS1, Line 1742: if (bts->nokia.configured != 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/0f262026_179d0423?usp=... : PS1, Line 1742: if (bts->nokia.configured != 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/d272f23a_b5248b09?usp=... : PS1, Line 1743: /* start TRX (RSL link) */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/5f33749b_539f6eca?usp=... : PS1, Line 1745: struct gsm_e1_subslot *e1_link = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/e97d0d6f_d37281a6?usp=... : PS1, Line 1745: struct gsm_e1_subslot *e1_link = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/60cff783_76c15f65?usp=... : PS1, Line 1746: &sign_link->trx->rsl_e1_link; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/c432aa5e_a78f9704?usp=... : PS1, Line 1746: &sign_link->trx->rsl_e1_link; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/41637b11_a2c21f3e?usp=... : PS1, Line 1747: struct e1inp_line *line; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/ac3188dc_c4355e03?usp=... : PS1, Line 1747: struct e1inp_line *line; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/706abc0e_3682a957?usp=... : PS1, Line 1749: bts->nokia.configured = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/68b492ea_612e4295?usp=... : PS1, Line 1749: bts->nokia.configured = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/c65637b8_d8476ee7?usp=... : PS1, Line 1751: /* RSL Link */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/de9780ef_f9924786?usp=... : PS1, Line 1752: line = e1inp_line_find(e1_link->e1_nr); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/9397c001_6946c948?usp=... : PS1, Line 1752: line = e1inp_line_find(e1_link->e1_nr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/9832029c_1d92b964?usp=... : PS1, Line 1753: if (!line) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/136ddd69_d45ab1e1?usp=... : PS1, Line 1753: if (!line) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/fc91a355_53a74af4?usp=... : PS1, Line 1754: LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/d4dde760_6aa27625?usp=... : PS1, Line 1754: LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to " please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/fdb586c1_c712dc54?usp=... : PS1, Line 1755: "non-existing E1 line %u\n", e1_link->e1_nr); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/cf206b7e_cfde6655?usp=... : PS1, Line 1755: "non-existing E1 line %u\n", e1_link->e1_nr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/4339f9f7_d45dc657?usp=... : PS1, Line 1756: return -ENOMEM; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/50aa6a9b_38468f71?usp=... : PS1, Line 1756: return -ENOMEM; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/b5ef161a_daafc0eb?usp=... : PS1, Line 1757: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/127994f1_181449d6?usp=... : PS1, Line 1757: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/0069ed79_97a361d9?usp=... : PS1, Line 1758: /* start TRX */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/9ac72d58_807d6d39?usp=... : PS1, Line 1759: start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843): https://gerrit.osmocom.org/c/osmo-bsc/+/39277/comment/2f2d4b86_0f697270?usp=... : PS1, Line 1759: start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */ please, no spaces at the start of a line
-
Jenkins Builder