View Change

27 comments:

• File src/osmo-bsc/bts_nokia_site.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1742: if (bts->nokia.configured != 0) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1742: if (bts->nokia.configured != 0) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1743: /* start TRX (RSL link) */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1745: struct gsm_e1_subslot *e1_link =

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1745: struct gsm_e1_subslot *e1_link =

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1746: &sign_link->trx->rsl_e1_link;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1746: &sign_link->trx->rsl_e1_link;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1747: struct e1inp_line *line;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1747: struct e1inp_line *line;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1749: bts->nokia.configured = 0;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1749: bts->nokia.configured = 0;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1751: /* RSL Link */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1752: line = e1inp_line_find(e1_link->e1_nr);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1752: line = e1inp_line_find(e1_link->e1_nr);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1753: if (!line) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1753: if (!line) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1754: LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to "

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1754: LOG_BTS(bts, DLINP, LOGL_ERROR, "RSL link referring to "

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1755: "non-existing E1 line %u\n", e1_link->e1_nr);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1755: "non-existing E1 line %u\n", e1_link->e1_nr);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1756: return -ENOMEM;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1756: return -ENOMEM;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1757: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1757: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1758: /* start TRX */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1759: start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20843):

    Patch Set #1, Line 1759: start_sabm_in_line(line, 1, SAPI_RSL); /* start only RSL */

    please, no spaces at the start of a line

To view, visit change 39277. To unsubscribe, or for help writing mail filters, visit settings.