Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support ......................................................................
Patch Set 14: Code-Review+1
(2 comments)
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23d9eb91_c878241d PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
abosolutely does not matter here, the directory layout has been unchanged for 10 years and this dire […]
The reason I had in mind here is not about changing dir structure, it's more about whether this relative path is properly handled when you have builddir != srcdir, etc.
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd2cf424_96ff42f4 PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
Done
By done you mean you disabled it by default?
-
pespin