Attention is currently required from: Hoernchen, laforge, fixeria.

Patch set 14:Code-Review +1

View Change

2 comments:

• File Transceiver52M/Makefile.am:

  • Patch Set #11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc

    abosolutely does not matter here, the directory layout has been unchanged for 10 years and this dire […]

    The reason I had in mind here is not about changing dir structure, it's more about whether this relative path is properly handled when you have builddir != srcdir, etc.

• File Transceiver52M/ms/ms_upper.cpp:

  • Patch Set #11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:

    Done

    By done you mean you disabled it by default?

To view, visit change 30416. To unsubscribe, or for help writing mail filters, visit settings.