Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic - gerrit-log

15 Nov 2022

Attention is currently required from: laforge.
jtavares has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/30139 )

Change subject: bankd: Add GSMTAP functionality for SIM traffic
......................................................................

Patch Set 4:

(4 comments)

File src/bankd/gsmtap.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/24f26a73_911cfbe4 
PS2, Line 28: osmo_bankd_gsmtap_init
...
  AFAIR, in simtrace2.git they are actually part of
libosmo-simtrace2. […] Ack

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/797ceb81_8c09e6d2 
PS2, Line 35: 		perror("unable to open GSMTAP");
...
  thanks for pointing this out, that's clearly a bug
in libosmo-simtrace2 then. Ack

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/2dad9545_26974017 
PS2, Line 56: 	uint8_t *buf = malloc(gross_len);
...
  Nice-- I'd never heard of writev(). Very useful.
[…] Ack

https://gerrit.osmocom.org/c/osmo-remsim/+/30139/comment/39602826_d6a4de6f 
PS2, Line 83: 		perr
...
  normally we'd want to use the libosmocore logging
framework with LOGL_ERROR here. Ack

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08
Gerrit-Change-Number: 30139
Gerrit-PatchSet: 4
Gerrit-Owner: jtavares &lt;jtavares(a)kvh.com&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Tue, 15 Nov 2022 02:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: jtavares &lt;jtavares(a)kvh.com&gt;
Gerrit-MessageType: comment